Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility #2

Merged
merged 2 commits into from
May 11, 2020
Merged

Accessibility #2

merged 2 commits into from
May 11, 2020

Conversation

dleadbetter
Copy link
Collaborator

This pull request adds the "a11y" addon to Storybook to support accessibility testing for Section 508 compliance. The addon displays an additional tab that lists elements that are not compliant with Section 508 standards:

Screen Shot 2020-05-11 at 1 50 03 PM

Some of the elements are indeed still failing, most due to an invalid color contract ratio. Since the components in this library are intended to be used in any number of projects, I think (but am open to suggestions) the accessibility changes should take place in the individual projects that required Section 508 compliance.

@dleadbetter dleadbetter requested a review from jamiefolsom May 11, 2020 17:53
jamiefolsom
jamiefolsom approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@jamiefolsom jamiefolsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree about allowing projects to implement their own solutions if necessary. If there are simple, global changes that would improve A11y throughout (like color or contrast, eg), it seems fine to me to implement those in the generic components.

@dleadbetter dleadbetter merged commit 71ec9b4 into master May 11, 2020
@dleadbetter dleadbetter deleted the feature/accessibility branch May 11, 2020 18:53
dleadbetter added a commit that referenced this pull request May 21, 2021
@dleadbetter
BASIRA #2 - Updating NestedAccordion to accept "styled" prop
f44a2a6
dleadbetter added a commit that referenced this pull request May 21, 2021
@dleadbetter
BASIRA #2 - Updating NestedAccordion to accept "styled" prop
26a9a91
dleadbetter added a commit that referenced this pull request Jun 1, 2021
@dleadbetter
Merge pull request #71 from performant-software/feature/basira2_physi…
3d286cf 
…cal_components

BASIRA #2 - Physical components
dleadbetter added a commit that referenced this pull request Aug 29, 2023
@dleadbetter
CDC #2 - Adding "editable" prop to SimpleEditPage component to condit…
7d3c5d6 
…ionally render save button
dleadbetter added a commit that referenced this pull request Aug 31, 2023
@dleadbetter
Merge pull request #199 from performant-software/feature/cdc1_projects
50fbe74 
CDC #2 - Projects
@rsimon rsimon mentioned this pull request Jan 31, 2024
Closed
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Adding optional "layerId" prop to LocationMarkers component
cbfd799
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Adding "truncate" function to /shared/utils/String
e173be1
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Publishing v2.1.0-beta.6
8a2134b
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Refactoring TypesenseUtils toFeature to use turfjs; Adding…
ae98e67 
… toFeatureCollection
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Publishing v2.1.0-beta.7
d25d239
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Updating toFeature to correctly get point geometry from co…
aeaf6bf 
…ordinates
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Publishing v2.1.0-beta.8
ea94822
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Fixing a bug with the toFeature logic for point geometries
2c2d390
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Publishing v2.1.0-beta.9
e3e1cea
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Updating name of base layers and data layers objects in ru…
cb06526 
…ntime config
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Publishing v2.1.0-beta.10
fffcf46
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Refactoring MapStyles and exporting
9555ec0
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Publishing v2.1.0-beta.11
c86914b
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Adding mapping components and utilities
a3fde48
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Adding I18n context
922cad9
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Exporting I18n context
4bfa743
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Publishing v2.1.0-beta.12
a18317f
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Fixing a bug in PeripleoUtils filterLayers function
b5ae81a
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Publishing v2.1.0-beta.13
15a99a7
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Updating LayerMenu logic for switching base layers
d9e88bb
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Publishing v2.1.0-beta.14
ab00490
dleadbetter pushed a commit that referenced this pull request Mar 18, 2024
Atlas #2 - Publishing v2.1.0-beta.15
7a91a55
dleadbetter pushed a commit that referenced this pull request Mar 20, 2024
Atlas #2 - Publishing v2.1.0-beta.16
184c199
dleadbetter pushed a commit that referenced this pull request Mar 20, 2024
Atlas #2 - Publishing v2.1.0-beta.17
f193acd
dleadbetter pushed a commit that referenced this pull request Mar 20, 2024
Atlas #2 - Publishing v2.1.0-beta.18
eb927c2
dleadbetter pushed a commit that referenced this pull request Mar 21, 2024
Atlas #2 - Publishing v2.1.0-beta.19
31cb6c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiefolsom jamiefolsom jamiefolsom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dleadbetter @jamiefolsom